A few fixes for image search:

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 172 matching lines @@
   { 47, IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS },
   { 48, IDC_CONTENT_CONTEXT_ADDSEARCHENGINE },
   { 49, IDC_CONTENT_CONTEXT_SPEECH_INPUT_FILTER_PROFANITIES },
   { 50, IDC_CONTENT_CONTEXT_SPEECH_INPUT_ABOUT },
   { 51, IDC_SPEECH_INPUT_MENU },
   { 52, IDC_CONTENT_CONTEXT_OPENLINKWITH },
   { 53, IDC_CHECK_SPELLING_WHILE_TYPING },
   { 54, IDC_SPELLCHECK_MENU },
   { 55, IDC_CONTENT_CONTEXT_SPELLING_TOGGLE },
   { 56, IDC_SPELLCHECK_LANGUAGES_FIRST },
-  { 57, IDC_CONTENT_CONTEXT_SEARCHIMAGENEWTAB },
+  { 57, IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE },
   // Add new items here and use |enum_id| from the next line.
   { 58, 0 },  // Must be the last. Increment |enum_id| when new IDC was added.
 };
 
 // Collapses large ranges of ids before looking for UMA enum.
 int CollapleCommandsForUMA(int id) {
   if (id >= IDC_CONTENT_CONTEXT_CUSTOM_FIRST &&
       id <= IDC_CONTENT_CONTEXT_CUSTOM_LAST) {
     return IDC_CONTENT_CONTEXT_CUSTOM_FIRST;
   }
@@ skipping 651 matching lines @@
   AppendPrintItem();
   const TemplateURL* const default_provider =
       TemplateURLServiceFactory::GetForProfile(profile_)->
           GetDefaultSearchProvider();
   if (!default_provider)
     return;
   SearchTermsData search_terms;
   if (!default_provider->image_url().empty() &&
       default_provider->image_url_ref().IsValidUsingTermsData(search_terms)) {
     menu_model_.AddItem(
-        IDC_CONTENT_CONTEXT_SEARCHIMAGENEWTAB,
+        IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE,
         l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_SEARCHWEBFORIMAGE,
                                    default_provider->short_name()));
   }
 }
 
 void RenderViewContextMenu::AppendAudioItems() {
   AppendMediaItems();
   menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVEAVAS,
                                   IDS_CONTENT_CONTEXT_SAVEAUDIOAS);
@@ skipping 392 matching lines @@
       PrefService* local_state = g_browser_process->local_state();
       DCHECK(local_state);
       // Test if file-selection dialogs are forbidden by policy.
       if (!local_state->GetBoolean(prefs::kAllowFileSelectionDialogs))
         return false;
 
       return params_.src_url.is_valid() &&
           ProfileIOData::IsHandledProtocol(params_.src_url.scheme());
     }
 
+    // The images shown in the most visited thumbnails can't be opened or
+    // searched for conventionally.

[Avi (use Gerrit), 2013/08/06 02:29:41]

crbug.com/2608 which was referenced earlier seems to imply that this was a hack.
Is this now permanent?

[Peter Kasting, 2013/08/06 17:24:32]

Yes, and I'm OK with that.

Sid is no longer on the team, and he marked the bug fixed when he checked in his
original quick fix, so no one has ever looked at doing a followup.

I tried to do things like right-click NTP images to get image context menu
options, but since they all use CSS background-image or other tricks that
prevent Chrome from showing image context menu options anyway, it seems
impossible to even try to trigger this.  If you dig deeply into the inspector
and fiddle until you get something clickable, the URL is just some chrome
internal scheme thing, and the resulting image isn't something there's really a
use case for trying to e.g. search for.  So I think it's fine to just nix the
TODO.  If someone someday comes up with a compelling use case and UI for doing
more here, they can always implement more functionality then.

     case IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB:
-    case IDC_CONTENT_CONTEXT_SEARCHIMAGENEWTAB:
-      // The images shown in the most visited thumbnails do not currently open
-      // in a new tab as they should. Disabling this context menu option for
-      // now, as a quick hack, before we resolve this issue (Issue = 2608).
-      // TODO(sidchat): Enable this option once this issue is resolved.
-      if (params_.src_url.scheme() == chrome::kChromeUIScheme ||
-          !params_.src_url.is_valid())
-        return false;
-      return true;
+    case IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE:
+      return params_.src_url.is_valid() &&
+          (params_.src_url.scheme() != chrome::kChromeUIScheme);
 
     case IDC_CONTENT_CONTEXT_COPYIMAGE:
       return !params_.is_image_blocked;
 
     // Media control commands should all be disabled if the player is in an
     // error state.
     case IDC_CONTENT_CONTEXT_PLAYPAUSE:
     case IDC_CONTENT_CONTEXT_LOOP:
       return (params_.media_flags &
               WebContextMenuData::MediaInError) == 0;
@@ skipping 325 matching lines @@
 
     case IDC_CONTENT_CONTEXT_COPYIMAGELOCATION:
     case IDC_CONTENT_CONTEXT_COPYAVLOCATION:
       WriteURLToClipboard(params_.src_url);
       break;
 
     case IDC_CONTENT_CONTEXT_COPYIMAGE:
       CopyImageAt(params_.x, params_.y);
       break;
 
-    case IDC_CONTENT_CONTEXT_SEARCHIMAGENEWTAB:
+    case IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE:
       GetImageThumbnailForSearch();
       break;
 
     case IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB:
     case IDC_CONTENT_CONTEXT_OPENAVNEWTAB:
       OpenURL(
           params_.src_url,
           params_.frame_url.is_empty() ? params_.page_url : params_.frame_url,
           params_.frame_id,
           NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_LINK);
@@ skipping 446 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }