Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2231393003: Revert of Optimized implementation of quickReject() (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
herb_g, msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Optimized implementation of quickReject() (patchset #12 id:260001 of https://codereview.chromium.org/2225393002/ ) Reason for revert: New assert triggering in the Chrome roll, https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/208750/steps/webkit_unit_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/FrameThrottlingTest.SynchronousLayoutInAnimationFrameCallback and breaks the SKNX_NO_SIMD bot, https://codereview.chromium.org/2236363004 Original issue's description: > Optimized implementation of quickReject() > > Impl Overview > (1) Keep the device clip bounds up to date. This > requires minimal additional work in a few places > throughout canvas. > (2) Keep track of if the ctm isScaleTranslate. Yes, > there's a function that does this, but it's slow > to call. > (3) Perform the src->device transform in quick reject, > then check intersection/nan. > > Other Notes: > (1) NaN and intersection checks are performed > simultaneously. > (2) We no longer quick reject infinity. > (3) Affine and perspective are both handled in the slow > case. > (4) SkRasterClip::isEmpty() is handled by the intersection > check. > > Performance on Nexus 6P: > 93.2ms -> 59.8ms > > Overall Android Jank Tests Performance Impact: > Should gain us a ms or two on some tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225393002 > > Committed: https://skia.googlesource.com/skia/+/d22a817ff57986407facd16af36320fc86ce02da TBR=reed@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5aeb2fa25384b9d3202a1e8c6cd6832038419fe6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -216 lines) Patch
D bench/QuickRejectBench.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +15 lines, -8 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkCanvas.cpp View 19 chunks +38 lines, -97 lines 0 comments Download
M tests/QuickRejectTest.cpp View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Optimized implementation of quickReject()
4 years, 4 months ago (2016-08-12 09:22:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231393003/1
4 years, 4 months ago (2016-08-12 09:22:28 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 09:22:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5aeb2fa25384b9d3202a1e8c6cd6832038419fe6

Powered by Google App Engine
This is Rietveld 408576698