Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2236363004: Guard .fVec by !defined(SKNX_NO_SIMD). (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Guard .fVec by !defined(SKNX_NO_SIMD). The fVec fields don't exist on the SKNX_NO_SIMD bot, even though SSE is available. Not sure if you want to revert and reland with this merged in (easier to revert later if needed) or just land this patch this on top. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236363004 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/core/SkCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
mtklein_C
4 years, 4 months ago (2016-08-12 09:32:07 UTC) #6
msarett
4 years, 4 months ago (2016-08-12 12:28:55 UTC) #9
On 2016/08/12 09:32:07, mtklein_C wrote:

Thanks for this!  Think I'll try to reland all at once, when I figure out the
Chrome roll.

Powered by Google App Engine
This is Rietveld 408576698