Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_manager.cc

Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 95126de421d1ca79cdc115bb0cad82cb4401f1e1..fc75c4ea4b0b031557e3261887c10ca0f22e7173 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -183,7 +183,8 @@ AutofillManager::AutofillManager(
       user_did_edit_autofilled_field_(false),
       external_delegate_(NULL),
       test_delegate_(NULL),
-      weak_ptr_factory_(this) {
+      weak_ptr_factory_(this),
+      username_to_remove_() {

[vabr (Chromium), 2014/04/09 14:06:30]

This should not be needed, please remove.

[rchtara, 2014/04/09 15:28:20]

Done.

   if (enable_download_manager == ENABLE_AUTOFILL_DOWNLOAD_MANAGER) {
     download_manager_.reset(
         new AutofillDownloadManager(driver,
@@ -1173,4 +1174,13 @@ bool AutofillManager::ShouldUploadForm(const FormStructure& form) {
   return true;
 }
 
+base::string16 AutofillManager::GetUserNameToRemove() {

[vabr (Chromium), 2014/04/09 14:06:30]

nit: you can name these two accessors
username_to_remove()
and
set_username_to_remove(), respectively, and put the definitions in the class
definition in the header file. It's allowed by the style guide, and makes the
code more readable (it's immediately clear from the function name, that it's
just a simple accessor).

[rchtara, 2014/04/09 15:28:20]

Done.

+  return username_to_remove_;
+}
+
+void AutofillManager::SetUserNameToRemove(
+    const base::string16& username_to_remove) {
+  username_to_remove_ = username_to_remove;
+}
+
 }  // namespace autofill