Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 165 matching lines @@
           new AutocompleteHistoryManager(driver, delegate)),
       metric_logger_(new AutofillMetrics),
       has_logged_autofill_enabled_(false),
       has_logged_address_suggestions_count_(false),
       did_show_suggestions_(false),
       user_did_type_(false),
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       external_delegate_(NULL),
       test_delegate_(NULL),
-      weak_ptr_factory_(this) {
+      weak_ptr_factory_(this),
+      username_to_remove_() {

[vabr (Chromium), 2014/04/09 14:06:30]

This should not be needed, please remove.

[rchtara, 2014/04/09 15:28:20]

Done.

   if (enable_download_manager == ENABLE_AUTOFILL_DOWNLOAD_MANAGER) {
     download_manager_.reset(
         new AutofillDownloadManager(driver,
                                     manager_delegate_->GetPrefs(),
                                     this));
   }
 }
 
 AutofillManager::~AutofillManager() {}
 
@@ skipping 969 matching lines @@
   if (driver_->IsOffTheRecord())
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed(true))
     return false;
 
   return true;
 }
 
+base::string16 AutofillManager::GetUserNameToRemove() {

[vabr (Chromium), 2014/04/09 14:06:30]

nit: you can name these two accessors
username_to_remove()
and
set_username_to_remove(), respectively, and put the definitions in the class
definition in the header file. It's allowed by the style guide, and makes the
code more readable (it's immediately clear from the function name, that it's
just a simple accessor).

[rchtara, 2014/04/09 15:28:20]

Done.

+  return username_to_remove_;
+}
+
+void AutofillManager::SetUserNameToRemove(
+    const base::string16& username_to_remove) {
+  username_to_remove_ = username_to_remove;
+}
+
 }  // namespace autofill