Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_messages.h
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index 9b01b5d2a61aa6c6da003472065b0c4e092c4d6a..f5a351c216febc5618d4817ef837f33da68d0979 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -159,6 +159,12 @@ IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,
IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
std::vector<autofill::FormData> /* forms */)
+// Instruct the renderer that a password suggestion has to be removed.
+// The renderer is going to clean the suggestion from the ui and
+// then ask the password manager to remove the password from the store.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RemovePasswordSuggestion,
+ base::string16 /*user name to be removed */)
+
// Autofill messages sent from the renderer to the browser.
// TODO(creis): check in the browser that the renderer actually has permission
@@ -257,6 +263,13 @@ IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
std::vector<base::string16> /* suggestions */,
std::vector<base::string16> /* realms */)
+// Instruct the browser that a password suggestion has to be removed.
vabr (Chromium) 2014/04/04 10:51:40 Actually, it's not a password suggestion, we like
rchtara 2014/04/04 16:07:20 Done.
+// Send also a list of forms that need to be updated after the deletion
vabr (Chromium) 2014/04/04 10:51:40 Missing full-stop (period).
rchtara 2014/04/04 16:07:20 Done.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemovePasswordSuggestion,
+ autofill::PasswordForm /* the password form */,
+ std::vector<autofill::PasswordForm> /* password
+ forms to be updated */)
+
// Inform browser of data list values for the curent field.
IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
std::vector<base::string16> /* values */,

Powered by Google App Engine
This is Rietveld 408576698