Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 

[vabr (Chromium), 2014/04/04 10:51:40]

nit: #include <vector> seems appropriate here.
This header file already uses std::vector on many places, so it get's included
through some of the other headers, but it won't hurt include it here explicitly.

 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/form_field_data_predictions.h"
 #include "components/autofill/core/common/forms_seen_state.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/autofill/core/common/web_element_descriptor.h"
@@ skipping 133 matching lines @@
 // autocomplete with the |form_data| values input by the user.
 IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,
                     blink::WebFormElement::AutocompleteResult /* result */,
                     autofill::FormData /* form_data */)
 
 // Sent when Autofill manager gets the query response from the Autofill server
 // and there are fields classified as ACCOUNT_CREATION_PASSWORD in the response.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
                     std::vector<autofill::FormData> /* forms */)
 
+// Instruct the renderer that a password suggestion has to be removed.
+// The renderer is going to clean the suggestion from the ui and
+// then ask the password manager to remove the password from the store.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RemovePasswordSuggestion,
+                    base::string16 /*user name to be removed */)
+
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission
 // for the URL to avoid compromised renderers talking to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen,
                     std::vector<autofill::FormData> /* forms */,
                     base::TimeTicks /* timestamp */,
@@ skipping 78 matching lines @@
                     autofill::PasswordFormFillData /* password pairings */)
 
 // Instruct the browser to show a popup with the following suggestions from the
 // password manager.
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
+// Instruct the browser that a password suggestion has to be removed.

[vabr (Chromium), 2014/04/04 10:51:40]

Actually, it's not a password suggestion, we like to remove. It's the saved
password, right?
If so, we should say "stored password" instead of "password suggestion" here,
and also change the name of the message.

[rchtara, 2014/04/04 16:07:20]

Done.

+// Send also a list of forms that need to be updated after the deletion

[vabr (Chromium), 2014/04/04 10:51:40]

Missing full-stop (period).

[rchtara, 2014/04/04 16:07:20]

Done.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemovePasswordSuggestion,
+                    autofill::PasswordForm /* the password form */,
+                    std::vector<autofill::PasswordForm> /* password
+                    forms to be updated */)
+
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)