fix #26120, sideways casts no longer supported

fix #26120, sideways casts no longer supported

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/e36fa2b3be32ae0f42d02a9ae28285b6214d2481

[Jennifer Messerly, 2016-08-10 22:24:06]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Jennifer Messerly, 2016-08-10 22:24:07]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right =
/*info:INVALID_ASSIGNMENT*/right;
note this hint. Analyzer seems to track which type was last assigned to the
variable, so it flags this. Anyway it would be easy to disable these hints if we
wanted to, but it seems harmless enough, since it only shows up in this example
which is intentionally doing bad things :). It is using our type system for the
hint.

[Brian Wilkerson, 2016-08-10 22:56:02]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-08-10 22:56:03]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right =
/*info:INVALID_ASSIGNMENT*/right;
The hint is a result of type propagation, which will be removed fairly
soon(ish).

[Jennifer Messerly, 2016-08-11 00:51:19]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right =
/*info:INVALID_ASSIGNMENT*/right;
On 2016/08/10 22:56:02, Brian Wilkerson wrote:
> The hint is a result of type propagation, which will be removed fairly
> soon(ish).

oh nice!

[vsm, 2016-08-12 20:47:00]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (left):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType &&
getCallMethodType(fromType) != null)) {
Hmm, this feels odd to remove - doesn't this allow more casts now?

[Jennifer Messerly, 2016-08-12 21:00:28]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (left):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType &&
getCallMethodType(fromType) != null)) {
On 2016/08/12 20:47:00, vsm wrote:
> Hmm, this feels odd to remove - doesn't this allow more casts now?

I was following instructions from TODO(vsm) here:
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ta...

[vsm, 2016-08-12 21:10:44]

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (left):

https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType &&
getCallMethodType(fromType) != null)) {
On 2016/08/12 21:00:28, John Messerly wrote:
> On 2016/08/12 20:47:00, vsm wrote:
> > Hmm, this feels odd to remove - doesn't this allow more casts now?
> 
> I was following instructions from TODO(vsm) here:
>
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/ta...

I get it now.  We're guaranteed to return false later on if the red is true.  We
don't need to extra check here.

[vsm, 2016-08-12 21:11:33]

lgtm

[Jennifer Messerly, 2016-08-12 21:32:40]

Description was changed from

==========
fix #26120, sideways casts no longer supported
==========

to

==========
fix #26120, sideways casts no longer supported

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e36fa2b3be32ae0f42d02a9ae28285b6214d2481
==========

[Jennifer Messerly, 2016-08-12 21:32:41]

Committed patchset #2 (id:20001) manually as
e36fa2b3be32ae0f42d02a9ae28285b6214d2481 (presubmit successful).