Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2231273002: fix #26120, sideways casts no longer supported (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf, vsm, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -101 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +2 lines, -3 lines 3 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 3 chunks +5 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 4 chunks +16 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 24 chunks +52 lines, -52 lines 3 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 6 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jennifer Messerly
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode1194 pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right = /*info:INVALID_ASSIGNMENT*/right; note this hint. Analyzer seems to ...
4 years, 4 months ago (2016-08-10 22:24:07 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode1194 pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right = /*info:INVALID_ASSIGNMENT*/right; The hint is a result of ...
4 years, 4 months ago (2016-08-10 22:56:03 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode1194 pkg/analyzer/test/src/task/strong/checker_test.dart:1194: right = /*info:INVALID_ASSIGNMENT*/right; On 2016/08/10 22:56:02, Brian Wilkerson wrote: ...
4 years, 4 months ago (2016-08-11 00:51:19 UTC) #5
vsm
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart File pkg/analyzer/lib/src/generated/type_system.dart (left): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart#oldcode358 pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType && getCallMethodType(fromType) != null)) { Hmm, ...
4 years, 4 months ago (2016-08-12 20:47:00 UTC) #6
Jennifer Messerly
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart File pkg/analyzer/lib/src/generated/type_system.dart (left): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart#oldcode358 pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType && getCallMethodType(fromType) != null)) { On ...
4 years, 4 months ago (2016-08-12 21:00:28 UTC) #7
vsm
https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart File pkg/analyzer/lib/src/generated/type_system.dart (left): https://codereview.chromium.org/2231273002/diff/20001/pkg/analyzer/lib/src/generated/type_system.dart#oldcode358 pkg/analyzer/lib/src/generated/type_system.dart:358: (toType is FunctionType && getCallMethodType(fromType) != null)) { On ...
4 years, 4 months ago (2016-08-12 21:10:44 UTC) #8
vsm
lgtm
4 years, 4 months ago (2016-08-12 21:11:33 UTC) #9
Jennifer Messerly
4 years, 4 months ago (2016-08-12 21:32:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e36fa2b3be32ae0f42d02a9ae28285b6214d2481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698