Chromium Code Reviews Chromium Code Reviews
Issue 2231153002:
MD Settings: Checks the event target in the language tap event handler (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/settings/languages_page/languages_page.html |
| diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html |
| index 040a5eb2bb1a799015d175bdc0a058e4cf1b2d1c..006d5cf8d773a1b93e6273efe49785129ce2dcee 100644 |
| --- a/chrome/browser/resources/settings/languages_page/languages_page.html |
| +++ b/chrome/browser/resources/settings/languages_page/languages_page.html |
| @@ -31,6 +31,10 @@ |
| .list-button { |
| @apply(--settings-actionable); |
| } |
| + |
| + .language-title-wrapper { |
| + flex: 1; |
| + } |
| </style> |
| <settings-languages languages="{{languages}}"></settings-languages> |
| <settings-animated-pages id="pages" section="languages"> |
| @@ -59,24 +63,26 @@ |
| <template is="dom-repeat" items="[[languages.enabled]]"> |
| <div class$="list-item [[getLanguageItemClass_( |
|
Dan Beam
2016/08/12 01:43:43
why are these both .list-item
Moe
2016/08/12 16:46:53
again to maintain appearance.
|
| item.language.code, prefs.intl.app_locale.value, |
| - item.language.supportsUI)]]" |
| - on-tap="onLanguageTap_"> |
| + item.language.supportsUI)]]"> |
| + <div class="list-item language-title-wrapper" |
|
Dan Beam
2016/08/12 01:43:43
why is this a list-item?
Moe
2016/08/12 16:46:53
to maintain the appearance. '.list-item' gives the
|
| + on-tap="onLanguageTap_"> |
| <if expr="not chromeos and not is_win"> |
| - <div class="start" title="[[item.language.nativeDisplayName]]"> |
| - [[item.language.displayName]] |
| - </div> |
| + <div class="start" title="[[item.language.nativeDisplayName]]"> |
| + [[item.language.displayName]] |
| + </div> |
| </if> |
| <if expr="chromeos or is_win"> |
| - <div title="[[item.language.nativeDisplayName]]"> |
| - [[item.language.displayName]] |
| - </div> |
| - <div class="middle"> |
| - <iron-icon icon="settings:done" |
| - hidden$="[[!isProspectiveUILanguage_( |
| - item.language.code, prefs.intl.app_locale.value)]]"> |
| - </iron-icon> |
| - </div> |
| + <div title="[[item.language.nativeDisplayName]]"> |
| + [[item.language.displayName]] |
| + </div> |
| + <div class="middle"> |
| + <iron-icon icon="settings:done" |
| + hidden$="[[!isProspectiveUILanguage_( |
| + item.language.code, prefs.intl.app_locale.value)]]"> |
| + </iron-icon> |
| + </div> |
| </if> |
| + </div> |
| <paper-icon-button id="more-[[item.language.code]]" |
| icon="cr:more-vert" toggles |
| active="{{item.optionsMenuOpened}}"> |
