MD Settings: Checks the event target in the language tap event handler

chrome/browser/resources/settings/languages_page/languages_page.html

 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/cr.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
@@ skipping 13 matching lines @@
 <if expr="chromeos">
 <link rel="import" href="manage_input_methods_page.html">
 </if>
 
 <dom-module id="settings-languages-page">
   <template>
     <style include="settings-shared">
       .list-button {
         @apply(--settings-actionable);
       }
+
+      .language-title-wrapper {
+        flex: 1;
+      }
     </style>
     <settings-languages languages="{{languages}}"></settings-languages>
     <settings-animated-pages id="pages" section="languages">
       <neon-animatable id="main">
         <div id="manage-languages-subpage-trigger"
             class="settings-box first two-line">
           <div class="start">
             <div>$i18n{languagesListTitle}</div>
             <div class="secondary">
               [[getProspectiveUILanguageName_(
                     languages, prefs.intl.app_locale.value)]]
             </div>
           </div>
           <cr-expand-button expanded="{{languagesOpened_}}">
           </cr-expand-button>
         </div>
         <iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]">
           <div class="list-frame vertical-list">
             <span class="list-item"
                 hidden="[[isHelpTextHidden_(languages.enabled.*)]]">
               <span>$i18n{orderLanguagesInstructions}</span>
               <a href="$i18n{languagesLearnMoreURL}" target="_blank">
                 $i18n{learnMore}
               </a>
             </span>
             <template is="dom-repeat" items="[[languages.enabled]]">
               <div class$="list-item [[getLanguageItemClass_(

[Dan Beam, 2016/08/12 01:43:43]

why are these both .list-item

[Moe, 2016/08/12 16:46:53]

again to maintain appearance.

                   item.language.code, prefs.intl.app_locale.value,
-                  item.language.supportsUI)]]"
-                  on-tap="onLanguageTap_">
+                  item.language.supportsUI)]]">
+                <div class="list-item language-title-wrapper"

[Dan Beam, 2016/08/12 01:43:43]

why is this a list-item?

[Moe, 2016/08/12 16:46:53]

to maintain the appearance. '.list-item' gives the wrapper div all the good flex
stuff.

+                    on-tap="onLanguageTap_">
 <if expr="not chromeos and not is_win">
-                <div class="start" title="[[item.language.nativeDisplayName]]">
-                  [[item.language.displayName]]
-                </div>
+                  <div class="start" title="[[item.language.nativeDisplayName]]">
+                    [[item.language.displayName]]
+                  </div>
 </if>
 <if expr="chromeos or is_win">
-                <div title="[[item.language.nativeDisplayName]]">
-                  [[item.language.displayName]]
+                  <div title="[[item.language.nativeDisplayName]]">
+                    [[item.language.displayName]]
+                  </div>
+                  <div class="middle">
+                    <iron-icon icon="settings:done"
+                        hidden$="[[!isProspectiveUILanguage_(
+                            item.language.code, prefs.intl.app_locale.value)]]">
+                    </iron-icon>
+                  </div>
+</if>
                 </div>
-                <div class="middle">
-                  <iron-icon icon="settings:done"
-                      hidden$="[[!isProspectiveUILanguage_(
-                          item.language.code, prefs.intl.app_locale.value)]]">
-                  </iron-icon>
-                </div>
-</if>
                 <paper-icon-button id="more-[[item.language.code]]"
                     icon="cr:more-vert" toggles
                     active="{{item.optionsMenuOpened}}">
                 </paper-icon-button>
                 <iron-dropdown opened="{{item.optionsMenuOpened}}"
                     horizontal-align="right" vertical-align="auto">
                   <div class="dropdown-content">
                     <button class="dropdown-item" role="option"
                         on-tap="onMoveUpTap_"
                         hidden="[[isFirstLanguage_(index,
@@ skipping 127 matching lines @@
             associated-control="[[$$('#spellcheck-subpage-trigger')]]"
             page-title="$i18n{editDictionaryPageTitle}">
           <settings-edit-dictionary-page></settings-edit-dictionary-page>
         </settings-subpage>
       </template>
 </if>
     </settings-animated-pages>
   </template>
   <script src="languages_page.js"></script>
 </dom-module>