Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 2231083002: Disables readability/fn_sizes for v8. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index dd3533bcf40c91966c455fefb9cb450a24cb8bec..d503538fcba70e27ca919a762f29f6ed08c4406e 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -55,12 +55,15 @@ from testrunner.local import utils
# build/include_what_you_use: Started giving false positives for variables
# named "string" and "map" assuming that you needed to include STL headers.
# TODO(bmeurer): Fix and re-enable readability/check
+# TODO(epertoso): Maybe re-enable readability/fn_size after
+# http://crrev.com/2199323003 relands.
LINT_RULES = """
-build/header_guard
-build/include_what_you_use
-build/namespaces
-readability/check
+-readability/fn_size
+readability/streams
-runtime/references
""".split()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698