OLD | NEW |
1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
2 # | 2 # |
3 # Copyright 2012 the V8 project authors. All rights reserved. | 3 # Copyright 2012 the V8 project authors. All rights reserved. |
4 # Redistribution and use in source and binary forms, with or without | 4 # Redistribution and use in source and binary forms, with or without |
5 # modification, are permitted provided that the following conditions are | 5 # modification, are permitted provided that the following conditions are |
6 # met: | 6 # met: |
7 # | 7 # |
8 # * Redistributions of source code must retain the above copyright | 8 # * Redistributions of source code must retain the above copyright |
9 # notice, this list of conditions and the following disclaimer. | 9 # notice, this list of conditions and the following disclaimer. |
10 # * Redistributions in binary form must reproduce the above | 10 # * Redistributions in binary form must reproduce the above |
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
48 | 48 |
49 from testrunner.local import statusfile | 49 from testrunner.local import statusfile |
50 from testrunner.local import testsuite | 50 from testrunner.local import testsuite |
51 from testrunner.local import utils | 51 from testrunner.local import utils |
52 | 52 |
53 # Special LINT rules diverging from default and reason. | 53 # Special LINT rules diverging from default and reason. |
54 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". | 54 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". |
55 # build/include_what_you_use: Started giving false positives for variables | 55 # build/include_what_you_use: Started giving false positives for variables |
56 # named "string" and "map" assuming that you needed to include STL headers. | 56 # named "string" and "map" assuming that you needed to include STL headers. |
57 # TODO(bmeurer): Fix and re-enable readability/check | 57 # TODO(bmeurer): Fix and re-enable readability/check |
| 58 # TODO(epertoso): Maybe re-enable readability/fn_size after |
| 59 # http://crrev.com/2199323003 relands. |
58 | 60 |
59 LINT_RULES = """ | 61 LINT_RULES = """ |
60 -build/header_guard | 62 -build/header_guard |
61 -build/include_what_you_use | 63 -build/include_what_you_use |
62 -build/namespaces | 64 -build/namespaces |
63 -readability/check | 65 -readability/check |
| 66 -readability/fn_size |
64 +readability/streams | 67 +readability/streams |
65 -runtime/references | 68 -runtime/references |
66 """.split() | 69 """.split() |
67 | 70 |
68 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') | 71 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') |
69 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") | 72 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") |
70 | 73 |
71 def CppLintWorker(command): | 74 def CppLintWorker(command): |
72 try: | 75 try: |
73 process = subprocess.Popen(command, stderr=subprocess.PIPE) | 76 process = subprocess.Popen(command, stderr=subprocess.PIPE) |
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
486 success &= CheckExternalReferenceRegistration(workspace) | 489 success &= CheckExternalReferenceRegistration(workspace) |
487 success &= CheckStatusFiles(workspace) | 490 success &= CheckStatusFiles(workspace) |
488 if success: | 491 if success: |
489 return 0 | 492 return 0 |
490 else: | 493 else: |
491 return 1 | 494 return 1 |
492 | 495 |
493 | 496 |
494 if __name__ == '__main__': | 497 if __name__ == '__main__': |
495 sys.exit(Main()) | 498 sys.exit(Main()) |
OLD | NEW |