Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2231083002: Disables readability/fn_sizes for v8. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disables readability/fn_sizes for v8. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/c78c499a648b3c609ac89d639e2fbbb9b89fe231 Cr-Commit-Position: refs/heads/master@{#38546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/presubmit.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
epertoso
4 years, 4 months ago (2016-08-10 15:11:17 UTC) #3
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-10 15:14:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231083002/1
4 years, 4 months ago (2016-08-10 15:14:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 15:15:11 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 15:15:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c78c499a648b3c609ac89d639e2fbbb9b89fe231
Cr-Commit-Position: refs/heads/master@{#38546}

Powered by Google App Engine
This is Rietveld 408576698