Chromium Code Reviews
Help | Chromium Project | Sign in
(37)

Issue 2230983003: Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by tonikitoo
Modified:
7 months, 2 weeks ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction ... rather then doing c-style type cast. CL also tweaks the method body a bit to have more early-returns rather than too-nested-if blocks. No behavior change is expected, so no new tests are being added. Committed: https://pdfium.googlesource.com/pdfium/+/401d4f235114d7857c9c284a70cbb53a3e49bca1

Patch Set 1 #

Patch Set 2 : Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M fpdfsdk/fpdfformfill.cpp View 1 1 chunk +22 lines, -16 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (5 generated)
tonikitoo
7 months, 2 weeks ago (2016-08-10 18:21:48 UTC) #3
dsinclair
lgtm
7 months, 2 weeks ago (2016-08-10 18:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230983003/20001
7 months, 2 weeks ago (2016-08-10 18:26:07 UTC) #7
commit-bot: I haz the power
7 months, 2 weeks ago (2016-08-10 18:37:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/401d4f235114d7857c9c284a70cbb53a3e49...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62