Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

... rather then doing c-style type cast.

CL also tweaks the method body a bit to have more early-returns
rather than too-nested-if blocks.

No behavior change is expected, so no new tests are being added.

Committed: https://pdfium.googlesource.com/pdfium/+/401d4f235114d7857c9c284a70cbb53a3e49bca1

[tonikitoo, 2016-08-10 15:26:25]

Description was changed from

==========
Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

... rather then doing c-style type cast.

CL also tweaks the method body a bit to have more early-returns
rather than too-nested-if blocks.

Merge CPDFSDK_FormActionHandler into CPDFSDK_ActionHandler

The benefits of having a CPDFSDK_FormActionHandler instance in
CPDFSDK_ActionHandler are unclear. It does not add encapsulation, nor
simplicity to the logic.

CL is a driven-by clean up that merges CPDFSDK_FormActionHandler into
CPDFSDK_ActionHandler.
It takes the opportunity to delete CPDFSDK_ActionHandler (now) empty
constructor and destructor, in favor of compiler-generated ones.

No behavior change is expected, so no new tests are being added.
==========

to

==========
Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

... rather then doing c-style type cast.

CL also tweaks the method body a bit to have more early-returns
rather than too-nested-if blocks.

No behavior change is expected, so no new tests are being added.
==========

[tonikitoo, 2016-08-10 18:21:47]

tonikitoo@igalia.com changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-08-10 18:25:55]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-08-10 18:25:55]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-10 18:25:56]

lgtm

[commit-bot: I haz the power, 2016-08-10 18:26:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:37:47]

Description was changed from

==========
Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

... rather then doing c-style type cast.

CL also tweaks the method body a bit to have more early-returns
rather than too-nested-if blocks.

No behavior change is expected, so no new tests are being added.
==========

to

==========
Use CPDFSDK_Document::FromFPDFFormHandle in ::FORM_DoPageAAction

... rather then doing c-style type cast.

CL also tweaks the method body a bit to have more early-returns
rather than too-nested-if blocks.

No behavior change is expected, so no new tests are being added.

Committed:
https://pdfium.googlesource.com/pdfium/+/401d4f235114d7857c9c284a70cbb53a3e49...
==========

[commit-bot: I haz the power, 2016-08-10 18:37:48]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/401d4f235114d7857c9c284a70cbb53a3e49...