Fix window/display bounds with multiple windows in mus.

Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG=625876, 614070
Committed: https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d
Cr-Commit-Position: refs/heads/master@{#411385}

[kylechar, 2016-08-10 15:47:18]

Description was changed from

==========
Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG=625876
==========

to

==========
Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG=625876,614070
==========

[kylechar, 2016-08-10 15:48:00]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-08-10 22:16:00]

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
File services/ui/display/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
services/ui/display/platform_screen_impl_ozone.cc:77: std::set<uint64_t>
all_displays_;
'all_displays_' -> 'all_displays'

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
services/ui/display/platform_screen_impl_ozone.cc:83: if (displays_.find(id) !=
displays_.end())
Can this function be called if something changes related to the display, such as
the size?

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display.cc (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.cc:172: return
platform_screen_->GetPrimaryDisplayId() == GetId();
GetId() -> id_

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.cc:215: UpdateEventRootLocation(&pointer_event);
Can you update root location of event directly? (same comment on 219).

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display.h (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.h:139: // of this display. For example, if the
origin of this diplay is (1800, 0)
diplay->display

[kylechar, 2016-08-11 15:00:37]

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
File services/ui/display/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
services/ui/display/platform_screen_impl_ozone.cc:77: std::set<uint64_t>
all_displays_;
On 2016/08/10 22:15:59, sky wrote:
> 'all_displays_' -> 'all_displays'

Done.

https://codereview.chromium.org/2230963003/diff/1/services/ui/display/platfor...
services/ui/display/platform_screen_impl_ozone.cc:83: if (displays_.find(id) !=
displays_.end())
On 2016/08/10 22:15:59, sky wrote:
> Can this function be called if something changes related to the display, such
as
> the size?

If the display size changes because of a display configuration request (also
things like adding/removing monitors) then yes OnDisplayModeChanged would be
called by DisplayConfigurator. I'm not handling that yet because we're missing a
bunch of things to make it happen, but it will need to be handled from here.

There is also the display size changing when running under Oxygen because the
user resized the XWindow. That is a totally different code path and I'm tempted
to just make the window a fixed size and force the user to resize via Display
Settings even under Oxygen. That would help to unify the on device and off
device code paths.

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display.cc (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.cc:172: return
platform_screen_->GetPrimaryDisplayId() == GetId();
On 2016/08/10 22:15:59, sky wrote:
> GetId() -> id_

Done.

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.cc:215: UpdateEventRootLocation(&pointer_event);
On 2016/08/10 22:15:59, sky wrote:
> Can you update root location of event directly? (same comment on 219).

Good idea. Done.

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display.h (right):

https://codereview.chromium.org/2230963003/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display.h:139: // of this display. For example, if the
origin of this diplay is (1800, 0)
On 2016/08/10 22:15:59, sky wrote:
> diplay->display

Done.

[sky, 2016-08-11 17:03:22]

LGTM

[kylechar, 2016-08-11 17:35:18]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 17:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:15:00]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-08-11 18:33:35]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:34:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:39:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 18:43:16]

Description was changed from

==========
Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG=625876,614070
==========

to

==========
Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG=625876,614070

Committed: https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d
Cr-Commit-Position: refs/heads/master@{#411385}
==========

[commit-bot: I haz the power, 2016-08-11 18:43:17]

Patchset 2 (id:??) landed as
https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d
Cr-Commit-Position: refs/heads/master@{#411385}