Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2237003002: Find display root ServerWindow for located events in mus. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, staraz_chromium.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_display
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Find display root ServerWindow for located events in mus. The EventDispatcher currently just grabs the root ServerWindow for the first display. This doesn't work with multiple displays, so use the root_location to find the correct Display. BUG=625876 Committed: https://crrev.com/375bfd94aa008c34400a35c7f13fc47523c66875 Cr-Commit-Position: refs/heads/master@{#411728}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fixes. #

Total comments: 2

Patch Set 3 : Fix for comment. #

Patch Set 4 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -15 lines) Patch
M ash/mus/root_window_controller.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/ws/event_dispatcher.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/event_dispatcher_delegate.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M services/ui/ws/event_dispatcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_manager_state.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/window_manager_state.cc View 1 2 3 2 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
kylechar
4 years, 4 months ago (2016-08-11 18:12:49 UTC) #2
sky
https://codereview.chromium.org/2237003002/diff/1/services/ui/ws/event_dispatcher_delegate.h File services/ui/ws/event_dispatcher_delegate.h (right): https://codereview.chromium.org/2237003002/diff/1/services/ui/ws/event_dispatcher_delegate.h#newcode67 services/ui/ws/event_dispatcher_delegate.h:67: virtual ServerWindow* GetRootWindowContaining(gfx::Point* location) = 0; Update description about ...
4 years, 4 months ago (2016-08-11 20:58:04 UTC) #3
kylechar
https://codereview.chromium.org/2237003002/diff/1/services/ui/ws/event_dispatcher_delegate.h File services/ui/ws/event_dispatcher_delegate.h (right): https://codereview.chromium.org/2237003002/diff/1/services/ui/ws/event_dispatcher_delegate.h#newcode67 services/ui/ws/event_dispatcher_delegate.h:67: virtual ServerWindow* GetRootWindowContaining(gfx::Point* location) = 0; On 2016/08/11 20:58:04, ...
4 years, 4 months ago (2016-08-12 16:09:11 UTC) #4
sky
This LGTM, please make sure root origins are 0,0 soonish though. https://codereview.chromium.org/2237003002/diff/1/services/ui/ws/window_manager_state.cc File services/ui/ws/window_manager_state.cc (right): ...
4 years, 4 months ago (2016-08-12 16:47:46 UTC) #5
kylechar
Thanks sky. I'm trying to figure out what needs to change to move the origin ...
4 years, 4 months ago (2016-08-12 17:25:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237003002/40001
4 years, 4 months ago (2016-08-12 17:25:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/260419)
4 years, 4 months ago (2016-08-12 18:18:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237003002/60001
4 years, 4 months ago (2016-08-12 18:24:18 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-12 19:22:18 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:24:41 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/375bfd94aa008c34400a35c7f13fc47523c66875
Cr-Commit-Position: refs/heads/master@{#411728}

Powered by Google App Engine
This is Rietveld 408576698