Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: ppapi/api/private/ppb_nacl_private.idl

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppb_nacl_private.idl
diff --git a/ppapi/api/private/ppb_nacl_private.idl b/ppapi/api/private/ppb_nacl_private.idl
index 1054723c85cb6badc7c54766ee130e0f4de1ac77..0a5084997ecc5f00477561d38455f3c1d88708f4 100644
--- a/ppapi/api/private/ppb_nacl_private.idl
+++ b/ppapi/api/private/ppb_nacl_private.idl
@@ -122,13 +122,15 @@ interface PPB_NaCl_Private {
[in] PP_CompletionCallback callback);
/* Report to the browser that translation of the pexe for |instance|
- * has finished. The browser may then store the translation in the
- * cache. The renderer must first have called GetNexeFd for the same
- * instance. (It is not guaranteed to, however; if there is an error
+ * has finished, or aborted with an error. If |success| is true, the
+ * browser may then store the translation in the cache. The renderer
+ * must first have called GetNexeFd for the same instance. (It is not
+ * guaranteed to, however; if there is an error on the browser side
jvoung (off chromium) 2013/08/06 18:35:28 I forget, what was this last part of the comment a
dmichael (off chromium) 2013/08/06 18:53:58 nit: probably should have a comma after "on the br
Derek Schuff 2013/08/06 21:21:13 Clarified.
Derek Schuff 2013/08/06 21:21:13 Done.
* or the file is too big for the cache, or the browser is in incognito
* mode, no notification will be delivered to the plugin.)
*/
- void ReportTranslationFinished([in] PP_Instance instance);
+ void ReportTranslationFinished([in] PP_Instance instance,
+ [in] PP_Bool success);
/* Return true if we are off the record.
*/

Powered by Google App Engine
This is Rietveld 408576698