Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

ppapi/api/private/ppb_nacl_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* This file contains NaCl private interfaces. This interface is not versioned
  * and is for internal Chrome use. It may change without notice. */
 
 #inline c
 #include "ppapi/c/private/pp_file_handle.h"
@@ skipping 104 matching lines @@
                     [in] str_t pexe_url,
                     [in] uint32_t abi_version,
                     [in] uint32_t opt_level,
                     [in] str_t last_modified,
                     [in] str_t etag,
                     [out] PP_Bool is_hit,
                     [out] PP_FileHandle nexe_handle,
                     [in] PP_CompletionCallback callback);
 
   /* Report to the browser that translation of the pexe for |instance|
-   * has finished. The browser may then store the translation in the
-   * cache. The renderer must first have called GetNexeFd for the same
-   * instance. (It is not guaranteed to, however; if there is an error
+   * has finished, or aborted with an error. If |success| is true, the
+   * browser may then store the translation in the cache. The renderer
+   * must first have called GetNexeFd for the same instance. (It is not
+   * guaranteed to, however; if there is an error on the browser side

[jvoung (off chromium), 2013/08/06 18:35:28]

I forget, what was this last part of the comment about?  It sounds like there is
an exception when the renderer does *not* call GetNexeFd.  Doesn't call
GetNexeFd, but the callback is called w/ an error code if the file is too big
for the cache, etc. ?

[dmichael (off chromium), 2013/08/06 18:53:58]

nit: probably should have a comma after "on the browser side"

[Derek Schuff, 2013/08/06 21:21:13]

Clarified.

[Derek Schuff, 2013/08/06 21:21:13]

Done.

    * or the file is too big for the cache, or the browser is in incognito
    * mode, no notification will be delivered to the plugin.)
    */
-  void ReportTranslationFinished([in] PP_Instance instance);
+  void ReportTranslationFinished([in] PP_Instance instance,
+                                 [in] PP_Bool success);
 
   /* Return true if we are off the record.
    */
   PP_Bool IsOffTheRecord();
 
   /* Return true if PNaCl is turned on.
    */
   PP_Bool IsPnaclEnabled();
 
   /* Display a UI message to the user. */
   PP_ExternalPluginResult ReportNaClError([in] PP_Instance instance,
                                           [in] PP_NaClError message_id);
 
   /* Opens a NaCl executable file in the application's extension directory
    * corresponding to the file URL and returns a file descriptor, or an invalid
    * handle on failure. |metadata| is left unchanged on failure.
    */
   PP_FileHandle OpenNaClExecutable([in] PP_Instance instance,
                                    [in] str_t file_url,
                                    [out] uint64_t file_token_lo,
                                    [out] uint64_t file_token_hi);
 };