Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: chrome/browser/nacl_host/pnacl_host_unittest.cc

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jvoung, dmichael reviews Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/nacl_host/pnacl_host.cc ('k') | chrome/renderer/pepper/pnacl_translation_resource_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/pnacl_host_unittest.cc
diff --git a/chrome/browser/nacl_host/pnacl_host_unittest.cc b/chrome/browser/nacl_host/pnacl_host_unittest.cc
index 7796aa61ab12ede8a22451010dd7f2d4cce0c0c8..cb5e8ef9bdd0a343559bd68d2e525260d90054f1 100644
--- a/chrome/browser/nacl_host/pnacl_host_unittest.cc
+++ b/chrome/browser/nacl_host/pnacl_host_unittest.cc
@@ -73,7 +73,7 @@ TEST_F(PnaclHostTest, BasicMiss) {
base::RunLoop().RunUntilIdle();
EXPECT_PENDING_TRANSLATIONS(1);
ExpectCallbackCount(1);
- host_->TranslationFinished(0, 0);
+ host_->TranslationFinished(0, 0, true);
EXPECT_PENDING_TRANSLATIONS(0);
host_->RendererClosing(0);
}
@@ -89,7 +89,7 @@ TEST_F(PnaclHostTest, BadArguments) {
base::Bind(&PnaclHostTest::CallbackExpectMiss, base::Unretained(this)));
EXPECT_PENDING_TRANSLATIONS(1);
- host_->TranslationFinished(0, 1); // nonexistent translation
+ host_->TranslationFinished(0, 1, true); // nonexistent translation
EXPECT_PENDING_TRANSLATIONS(1);
host_->RendererClosing(1); // nonexistent renderer
EXPECT_PENDING_TRANSLATIONS(1);
« no previous file with comments | « chrome/browser/nacl_host/pnacl_host.cc ('k') | chrome/renderer/pepper/pnacl_translation_resource_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698