chrome/browser/nacl_host/pnacl_host.cc - Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_host.cc

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jvoung, dmichael reviews Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/nacl_host/pnacl_host.cc

diff --git a/chrome/browser/nacl_host/pnacl_host.cc b/chrome/browser/nacl_host/pnacl_host.cc

index 6eb3ea0a9b77bacd0a75dfa850a00f4d8e513d87..9bb5b727e14ca23f225c0d10b9dd31e83d46bba5 100644

--- a/chrome/browser/nacl_host/pnacl_host.cc

+++ b/chrome/browser/nacl_host/pnacl_host.cc

@@ -180,7 +180,9 @@ void PnaclHost::GetNexeFd(int render_process_id,

/////////////////// Cleanup

-void PnaclHost::TranslationFinished(int render_process_id, int pp_instance) {

+void PnaclHost::TranslationFinished(int render_process_id,

+ int pp_instance,

+ bool success) {

DCHECK(thread_checker_.CalledOnValidThread());

if (cache_state_ != CacheReady)

return;

« no previous file with comments | « chrome/browser/nacl_host/pnacl_host.h ('k') | chrome/browser/nacl_host/pnacl_host_unittest.cc » ('j') | no next file with comments »