Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2230813002: Use smart pointers for class owned pointers in xfa/fwl/theme (Closed)

Created:
4 years, 4 months ago by Wei Li
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use smart pointers for class owned pointers in xfa/fwl/theme Use smart pointers instead of raw pointer to make memory management easier for classes under xfa/fwl/theme. BUG=pdfium:518 Committed: https://pdfium.googlesource.com/pdfium/+/4e62b5c7c5a35c7020d581fb65de4b3fc5ad3c1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -107 lines) Patch
M xfa/fwl/theme/cfwl_checkboxtp.h View 2 chunks +28 lines, -23 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 14 chunks +25 lines, -14 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.h View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.cpp View 2 chunks +2 lines, -36 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.h View 3 chunks +13 lines, -10 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.h View 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Wei Li
pls review, thanks
4 years, 4 months ago (2016-08-10 17:47:53 UTC) #12
dsinclair
lgtm
4 years, 4 months ago (2016-08-10 18:29:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230813002/40001
4 years, 4 months ago (2016-08-10 18:29:39 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:30:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/4e62b5c7c5a35c7020d581fb65de4b3fc5ad...

Powered by Google App Engine
This is Rietveld 408576698