xfa/fwl/theme/cfwl_datetimepickertp.cpp - Issue 2230813002: Use smart pointers for class owned pointers in xfa/fwl/theme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/theme/cfwl_datetimepickertp.cpp

Issue 2230813002: Use smart pointers for class owned pointers in xfa/fwl/theme (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fwl/theme/cfwl_datetimepickertp.cpp

diff --git a/xfa/fwl/theme/cfwl_datetimepickertp.cpp b/xfa/fwl/theme/cfwl_datetimepickertp.cpp

index a303a4ea1f76e69677890178daeb4bf43223a0a3..d43694c6db19849858d84271311a806b7c8bfbc5 100644

--- a/xfa/fwl/theme/cfwl_datetimepickertp.cpp

+++ b/xfa/fwl/theme/cfwl_datetimepickertp.cpp

@@ -9,14 +9,9 @@

#include "xfa/fwl/basewidget/ifwl_datetimepicker.h"

#include "xfa/fwl/core/cfwl_themebackground.h"

-CFWL_DateTimePickerTP::CFWL_DateTimePickerTP() {

- m_pThemeData = new DTPThemeData;

- initThemeData();

+CFWL_DateTimePickerTP::CFWL_DateTimePickerTP() {}

-CFWL_DateTimePickerTP::~CFWL_DateTimePickerTP() {

- delete m_pThemeData;

+CFWL_DateTimePickerTP::~CFWL_DateTimePickerTP() {}

bool CFWL_DateTimePickerTP::IsValidWidget(IFWL_Widget* pWidget) {

return pWidget && pWidget->GetClassID() == FWL_Type::DateTimePicker;

@@ -72,32 +67,3 @@ void CFWL_DateTimePickerTP::DrawDropDownButton(CFWL_ThemeBackground* pParams,

FWLTHEME_DIRECTION_Down, eState, pMatrix);

}

-void CFWL_DateTimePickerTP::initThemeData() {

- uint32_t* pData = (uint32_t*)&m_pThemeData->BoxBkColor;

- *pData++ = 0;

- *pData++ = ArgbEncode(255, 220, 220, 215),