Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Issue 2230803005: [LayoutNG] Add writing-mode and direction to NGFragmentBase (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add writing-mode and direction to NGFragmentBase Add enum and fields for writing-mode and text-direction to the fragment base class. Also change how the type is specified and adds a DCHECK for setOffset ensuring it can only be called once. BUG=635619 R=ikilpatrick@chromium.org, glebl@chromium.org NOTRY=true Committed: https://crrev.com/65969ab53d68adaba42b188b24b9bb766130f41c Cr-Commit-Position: refs/heads/master@{#411193}

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Patch Set 3 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -16 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h View 3 chunks +29 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text.h View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
eae
4 years, 4 months ago (2016-08-10 20:16:05 UTC) #1
cbiesinger
lgtm
4 years, 4 months ago (2016-08-10 21:02:09 UTC) #4
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-10 21:02:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230803005/1
4 years, 4 months ago (2016-08-10 21:16:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120233) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 21:24:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230803005/20001
4 years, 4 months ago (2016-08-10 21:33:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230803005/40001
4 years, 4 months ago (2016-08-10 23:46:47 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 23:55:45 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:58:33 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65969ab53d68adaba42b188b24b9bb766130f41c
Cr-Commit-Position: refs/heads/master@{#411193}

Powered by Google App Engine
This is Rietveld 408576698