Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2230793003:
NavigationEntry: copy has_user_gesture_ in Clone() (Closed)
|
Created:
4 years, 4 months ago by Takashi Toyoshima Modified:
4 years, 4 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, qinmin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionNavigationEntry: copy has_user_gesture_ in Clone()
Usually, each member in NavigationEntry should be copied in Clone().
But, mistakenly has_user_gesture_ is not handled after r342388.
BUG=512633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/c3bc89b6ab02c27de0bafb046b75e299164d3d0d
Cr-Commit-Position: refs/heads/master@{#411144}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 ========== to ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
toyoshim@chromium.org changed reviewers: + creis@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
split from https://codereview.chromium.org/2174293002/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Note: telemetry_perf_unittests failures of win_chromium_x64_rel_ng isn't related to this change (because the changed code path is disabled on Windows). It seems happening on other CLs.
LGTM! Thanks for catching this one.
The CQ bit was checked by creis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== NavigationEntry: copy has_user_gesture_ in Clone() Usually, each member in NavigationEntry should be copied in Clone(). But, mistakenly has_user_gesture_ is not handled after r342388. BUG=512633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/c3bc89b6ab02c27de0bafb046b75e299164d3d0d Cr-Commit-Position: refs/heads/master@{#411144} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c3bc89b6ab02c27de0bafb046b75e299164d3d0d Cr-Commit-Position: refs/heads/master@{#411144} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
