Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 223063002: Revert of Fix ASSERT failure in RenderGeomtryMap for SVGs (Closed)

Created:
6 years, 8 months ago by hartmanng
Modified:
6 years, 8 months ago
Reviewers:
Stephen Chennney, fs
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr, rwlbuis, Ian Vollick
Visibility:
Public.

Description

Revert of Fix ASSERT failure in RenderGeomtryMap for SVGs (https://codereview.chromium.org/143363004/) Reason for revert: This broke rendering in Google Presentations (https://code.google.com/p/chromium/issues/detail?id=359142). Original issue's description: > Fix ASSERT failure in RenderGeomtryMap for SVGs > > SVGRenderSupport::mapLocalToContainer() was trying to apply transforms > in the incorrect order. Specifically, it would attempt to apply its > localToParentTransform before its localToBorderBoxTransform. This > was causing an ASSERT to fail when the computed transforms didn't > match up to those computed by RenderGeometryMap. > > BUG=302719 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167941 TBR=fs@opera.com,schenney@chromium.org NOTREECHECKS=true NOTRY=true BUG=302719 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170714

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
D LayoutTests/svg/transforms/svg-geometry-crash.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/svg/transforms/svg-geometry-crash-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hartmanng
Created Revert of Fix ASSERT failure in RenderGeomtryMap for SVGs
6 years, 8 months ago (2014-04-02 22:51:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/223063002/1
6 years, 8 months ago (2014-04-02 22:51:59 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 22:52:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-02 22:52:16 UTC) #4
Stephen Chennney
You'll probably need to revert manually using drover.
6 years, 8 months ago (2014-04-02 23:00:04 UTC) #5
hartmanng
On 2014/04/02 23:00:04, Stephen Chenney wrote: > You'll probably need to revert manually using drover. ...
6 years, 8 months ago (2014-04-02 23:03:10 UTC) #6
hartmanng
The CQ bit was checked by hartmanng@chromium.org
6 years, 8 months ago (2014-04-02 23:05:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/223063002/80001
6 years, 8 months ago (2014-04-02 23:05:36 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 23:06:09 UTC) #9
Message was sent while issue was closed.
Change committed as 170714

Powered by Google App Engine
This is Rietveld 408576698