third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp

index d8f33504c81ac3d90c5e5e49290764d468c1912a..e310fb8dbb4a86a94508d84d10acb855438f53ed 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp

@@ -19,7 +19,7 @@ void BeginScrollDisplayItem::replay(GraphicsContext& context) const

void BeginScrollDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

WebDisplayItemList::ScrollContainerId scrollContainerId = &client();

- list->appendScrollItem(visualRect, m_currentOffset, scrollContainerId);

+ list->appendScrollItem(m_currentOffset, scrollContainerId);

}

#ifndef NDEBUG

@@ -37,7 +37,7 @@ void EndScrollDisplayItem::replay(GraphicsContext& context) const

void EndScrollDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

- list->appendEndScrollItem(visualRect);

+ list->appendEndScrollItem();

}

} // namespace blink