third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

index 58d2f40c5f37cedd56612e5169d3e4729655f747..cde9a3c99881117026576217ac7b733d00d121e9 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

@@ -439,6 +439,7 @@ void PaintController::commitNewDisplayItems(const LayoutSize& offsetFromLayoutOb

if (gpuAnalyzer.suitableForGpuRasterization())

item.analyzeForGpuRasterization(gpuAnalyzer);

+ // TODO(wkorman): Only compute and append visual rect for drawings.

m_newDisplayItemList.appendVisualRect(visualRectForDisplayItem(item, offsetFromLayoutObject));

if (item.isCacheable()) {

@@ -512,6 +513,7 @@ void PaintController::appendDebugDrawingAfterCommit(const DisplayItemClient& dis

DCHECK(m_newDisplayItemList.isEmpty());

DrawingDisplayItem& displayItem = m_currentPaintArtifact.getDisplayItemList().allocateAndConstruct<DrawingDisplayItem>(displayItemClient, DisplayItem::DebugDrawing, picture);

displayItem.setSkippedCache();

+ // TODO(wkorman): Only compute and append visual rect for drawings.

m_currentPaintArtifact.getDisplayItemList().appendVisualRect(visualRectForDisplayItem(displayItem, offsetFromLayoutObject));

}