third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

index be857e6cee834c92ca4efcccbee1a8d48bc873cd..cf38fc4cc47b0865c5094d5c45dc7699c1c55b40 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

@@ -240,6 +240,8 @@ public:

void setSkippedCache() { m_skippedCache = true; }

bool skippedCache() const { return m_skippedCache; }

+ // TODO(wkorman): Only DrawingDisplayItem needs the visual rect argument.

+ // Consider refactoring class hierarchy to make this more explicit.

virtual void appendToWebDisplayItemList(const IntRect&, WebDisplayItemList*) const { }

// See comments of enum Type for usage of the following macros.