third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp

index cd12538e56d95b6e8206610e5d4cff1dba8b0fcb..7b9df256c97dbfe120bc4a7d21531f9bc3fa8962 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp

@@ -19,7 +19,7 @@ void BeginCompositingDisplayItem::replay(GraphicsContext& context) const

void BeginCompositingDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

SkRect bounds = m_bounds;

- list->appendCompositingItem(visualRect, m_opacity, m_xferMode,

+ list->appendCompositingItem(m_opacity, m_xferMode,

m_hasBounds ? &bounds : nullptr,

GraphicsContext::WebCoreColorFilterToSkiaColorFilter(m_colorFilter).get());

}

@@ -41,7 +41,7 @@ void EndCompositingDisplayItem::replay(GraphicsContext& context) const

void EndCompositingDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

- list->appendEndCompositingItem(visualRect);

+ list->appendEndCompositingItem();

}

} // namespace blink