third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp

index 75a305bfdb9358b3d288b1650c9c7911e3306c71..80a8ebc97251fe4ed21c11d57c35b95161f28c9d 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp

@@ -32,7 +32,7 @@ void ClipDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebD

for (size_t i = 0; i < m_roundedRectClips.size(); ++i)

webRoundedRects[i] = m_roundedRectClips[i];

- list->appendClipItem(visualRect, m_clipRect, webRoundedRects);

+ list->appendClipItem(m_clipRect, webRoundedRects);

}

void EndClipDisplayItem::replay(GraphicsContext& context) const

@@ -42,7 +42,7 @@ void EndClipDisplayItem::replay(GraphicsContext& context) const

void EndClipDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

- list->appendEndClipItem(visualRect);

+ list->appendEndClipItem();

}

#ifndef NDEBUG