Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
index 08926a77d196ec8d6960a495442fe5d75524d47d..f26ab817141e912c545a20d435e9614e7e19f545 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
@@ -90,7 +90,7 @@ static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem,
if (!picture)
return;
gfx::Rect bounds = gfx::SkIRectToRect(picture->cullRect().roundOut());
- list->CreateAndAppendItem<cc::DrawingDisplayItem>(bounds, sk_ref_sp(picture));
+ list->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>(bounds, sk_ref_sp(picture));
}
}
@@ -103,13 +103,13 @@ static scoped_refptr<cc::DisplayItemList> recordPaintChunk(const PaintArtifact&
gfx::Transform translation;
translation.Translate(-combinedBounds.x(), -combinedBounds.y());
// TODO(jbroman, wkorman): What visual rectangle is wanted here?
- list->CreateAndAppendItem<cc::TransformDisplayItem>(gfx::Rect(), translation);
+ list->CreateAndAppendPairedBeginItem<cc::TransformDisplayItem>(translation);
const DisplayItemList& displayItems = artifact.getDisplayItemList();
for (const auto& displayItem : displayItems.itemsInPaintChunk(chunk))
appendDisplayItemToCcDisplayItemList(displayItem, list.get());
- list->CreateAndAppendItem<cc::EndTransformDisplayItem>(gfx::Rect());
+ list->CreateAndAppendPairedEndItem<cc::EndTransformDisplayItem>();
list->Finalize();
return list;
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698