Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Unified Diff: cc/playback/display_item_proto_factory.cc

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/display_item_list_unittest.cc ('k') | cc/test/fake_content_layer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_proto_factory.cc
diff --git a/cc/playback/display_item_proto_factory.cc b/cc/playback/display_item_proto_factory.cc
index 75de32344d5b8ab3e43d8ab03c0858eab24125c4..8677acca8f64e239b094331b9a2b8a0ebb80a1e8 100644
--- a/cc/playback/display_item_proto_factory.cc
+++ b/cc/playback/display_item_proto_factory.cc
@@ -26,44 +26,44 @@ void DisplayItemProtoFactory::AllocateAndConstruct(
std::vector<uint32_t>* used_engine_picture_ids) {
switch (proto.type()) {
case proto::DisplayItem::Type_Clip:
- list->CreateAndAppendItem<ClipDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<ClipDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndClip:
- list->CreateAndAppendItem<EndClipDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndClipDisplayItem>(proto);
return;
case proto::DisplayItem::Type_ClipPath:
- list->CreateAndAppendItem<ClipPathDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<ClipPathDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndClipPath:
- list->CreateAndAppendItem<EndClipPathDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndClipPathDisplayItem>(proto);
return;
case proto::DisplayItem::Type_Compositing:
- list->CreateAndAppendItem<CompositingDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<CompositingDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndCompositing:
- list->CreateAndAppendItem<EndCompositingDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndCompositingDisplayItem>(proto);
return;
case proto::DisplayItem::Type_Drawing:
- list->CreateAndAppendItem<DrawingDisplayItem>(
+ list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
visual_rect, proto, client_picture_cache, used_engine_picture_ids);
return;
case proto::DisplayItem::Type_Filter:
- list->CreateAndAppendItem<FilterDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<FilterDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndFilter:
- list->CreateAndAppendItem<EndFilterDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndFilterDisplayItem>(proto);
return;
case proto::DisplayItem::Type_FloatClip:
- list->CreateAndAppendItem<FloatClipDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<FloatClipDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndFloatClip:
- list->CreateAndAppendItem<EndFloatClipDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndFloatClipDisplayItem>(proto);
return;
case proto::DisplayItem::Type_Transform:
- list->CreateAndAppendItem<TransformDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(proto);
return;
case proto::DisplayItem::Type_EndTransform:
- list->CreateAndAppendItem<EndTransformDisplayItem>(visual_rect, proto);
+ list->CreateAndAppendPairedEndItem<EndTransformDisplayItem>(proto);
return;
}
« no previous file with comments | « cc/playback/display_item_list_unittest.cc ('k') | cc/test/fake_content_layer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698