Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: cc/playback/display_item_proto_factory.cc

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/playback/display_item_list_unittest.cc ('k') | cc/test/fake_content_layer_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/playback/display_item_proto_factory.h" 5 #include "cc/playback/display_item_proto_factory.h"
6 6
7 #include "cc/playback/clip_display_item.h" 7 #include "cc/playback/clip_display_item.h"
8 #include "cc/playback/clip_path_display_item.h" 8 #include "cc/playback/clip_path_display_item.h"
9 #include "cc/playback/compositing_display_item.h" 9 #include "cc/playback/compositing_display_item.h"
10 #include "cc/playback/drawing_display_item.h" 10 #include "cc/playback/drawing_display_item.h"
11 #include "cc/playback/filter_display_item.h" 11 #include "cc/playback/filter_display_item.h"
12 #include "cc/playback/float_clip_display_item.h" 12 #include "cc/playback/float_clip_display_item.h"
13 #include "cc/playback/transform_display_item.h" 13 #include "cc/playback/transform_display_item.h"
14 #include "cc/proto/display_item.pb.h" 14 #include "cc/proto/display_item.pb.h"
15 #include "ui/gfx/geometry/rect.h" 15 #include "ui/gfx/geometry/rect.h"
16 16
17 namespace cc { 17 namespace cc {
18 class ClientPictureCache; 18 class ClientPictureCache;
19 19
20 // static 20 // static
21 void DisplayItemProtoFactory::AllocateAndConstruct( 21 void DisplayItemProtoFactory::AllocateAndConstruct(
22 const gfx::Rect& visual_rect, 22 const gfx::Rect& visual_rect,
23 DisplayItemList* list, 23 DisplayItemList* list,
24 const proto::DisplayItem& proto, 24 const proto::DisplayItem& proto,
25 ClientPictureCache* client_picture_cache, 25 ClientPictureCache* client_picture_cache,
26 std::vector<uint32_t>* used_engine_picture_ids) { 26 std::vector<uint32_t>* used_engine_picture_ids) {
27 switch (proto.type()) { 27 switch (proto.type()) {
28 case proto::DisplayItem::Type_Clip: 28 case proto::DisplayItem::Type_Clip:
29 list->CreateAndAppendItem<ClipDisplayItem>(visual_rect, proto); 29 list->CreateAndAppendPairedBeginItem<ClipDisplayItem>(proto);
30 return; 30 return;
31 case proto::DisplayItem::Type_EndClip: 31 case proto::DisplayItem::Type_EndClip:
32 list->CreateAndAppendItem<EndClipDisplayItem>(visual_rect, proto); 32 list->CreateAndAppendPairedEndItem<EndClipDisplayItem>(proto);
33 return; 33 return;
34 case proto::DisplayItem::Type_ClipPath: 34 case proto::DisplayItem::Type_ClipPath:
35 list->CreateAndAppendItem<ClipPathDisplayItem>(visual_rect, proto); 35 list->CreateAndAppendPairedBeginItem<ClipPathDisplayItem>(proto);
36 return; 36 return;
37 case proto::DisplayItem::Type_EndClipPath: 37 case proto::DisplayItem::Type_EndClipPath:
38 list->CreateAndAppendItem<EndClipPathDisplayItem>(visual_rect, proto); 38 list->CreateAndAppendPairedEndItem<EndClipPathDisplayItem>(proto);
39 return; 39 return;
40 case proto::DisplayItem::Type_Compositing: 40 case proto::DisplayItem::Type_Compositing:
41 list->CreateAndAppendItem<CompositingDisplayItem>(visual_rect, proto); 41 list->CreateAndAppendPairedBeginItem<CompositingDisplayItem>(proto);
42 return; 42 return;
43 case proto::DisplayItem::Type_EndCompositing: 43 case proto::DisplayItem::Type_EndCompositing:
44 list->CreateAndAppendItem<EndCompositingDisplayItem>(visual_rect, proto); 44 list->CreateAndAppendPairedEndItem<EndCompositingDisplayItem>(proto);
45 return; 45 return;
46 case proto::DisplayItem::Type_Drawing: 46 case proto::DisplayItem::Type_Drawing:
47 list->CreateAndAppendItem<DrawingDisplayItem>( 47 list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
48 visual_rect, proto, client_picture_cache, used_engine_picture_ids); 48 visual_rect, proto, client_picture_cache, used_engine_picture_ids);
49 return; 49 return;
50 case proto::DisplayItem::Type_Filter: 50 case proto::DisplayItem::Type_Filter:
51 list->CreateAndAppendItem<FilterDisplayItem>(visual_rect, proto); 51 list->CreateAndAppendPairedBeginItem<FilterDisplayItem>(proto);
52 return; 52 return;
53 case proto::DisplayItem::Type_EndFilter: 53 case proto::DisplayItem::Type_EndFilter:
54 list->CreateAndAppendItem<EndFilterDisplayItem>(visual_rect, proto); 54 list->CreateAndAppendPairedEndItem<EndFilterDisplayItem>(proto);
55 return; 55 return;
56 case proto::DisplayItem::Type_FloatClip: 56 case proto::DisplayItem::Type_FloatClip:
57 list->CreateAndAppendItem<FloatClipDisplayItem>(visual_rect, proto); 57 list->CreateAndAppendPairedBeginItem<FloatClipDisplayItem>(proto);
58 return; 58 return;
59 case proto::DisplayItem::Type_EndFloatClip: 59 case proto::DisplayItem::Type_EndFloatClip:
60 list->CreateAndAppendItem<EndFloatClipDisplayItem>(visual_rect, proto); 60 list->CreateAndAppendPairedEndItem<EndFloatClipDisplayItem>(proto);
61 return; 61 return;
62 case proto::DisplayItem::Type_Transform: 62 case proto::DisplayItem::Type_Transform:
63 list->CreateAndAppendItem<TransformDisplayItem>(visual_rect, proto); 63 list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(proto);
64 return; 64 return;
65 case proto::DisplayItem::Type_EndTransform: 65 case proto::DisplayItem::Type_EndTransform:
66 list->CreateAndAppendItem<EndTransformDisplayItem>(visual_rect, proto); 66 list->CreateAndAppendPairedEndItem<EndTransformDisplayItem>(proto);
67 return; 67 return;
68 } 68 }
69 69
70 NOTREACHED(); 70 NOTREACHED();
71 } 71 }
72 72
73 } // namespace cc 73 } // namespace cc
OLDNEW
« no previous file with comments | « cc/playback/display_item_list_unittest.cc ('k') | cc/test/fake_content_layer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698