Re-adding analytical GeoProc for rectangles

Re-adding analytical GeoProc for rectangles

Adapted old GeoProc because its knowledge of the geometry is helpful for computing the distance vector: https://skia.googlesource.com/skia/+/6006d0f8c4f19d19a12de20826f731f52ac822a7/src/gpu/GrAARectRenderer.cpp

Added distance vector capabilities to this GeoProc.

Modified GrDrawContext to used this GeoProc when drawing anti-aliased vectors with a shader that requires distance vectors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004

Committed: https://skia.googlesource.com/skia/+/09e12a6d4a75d281c47e00a64eeba893ba096f9e

[dvonbeck, 2016-08-09 21:21:35]

Description was changed from

==========
Re-adding analytical GeoProc for rectangles

BUG=skia:
==========

to

==========
Re-adding analytical GeoProc for rectangles

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004
==========

[dvonbeck, 2016-08-09 21:36:01]

Description was changed from

==========
Re-adding analytical GeoProc for rectangles

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004
==========

to

==========
Re-adding analytical GeoProc for rectangles

Adapted old GeoProc because its knowledge of the geometry is helpful for
computing the distance vector:
https://skia.googlesource.com/skia/+/6006d0f8c4f19d19a12de20826f731f52ac822a7...

Added distance vector capabilities to this GeoProc.

Modified GrDrawContext to used this GeoProc when drawing anti-aliased vectors
with a shader that requires distance vectors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004
==========

[dvonbeck, 2016-08-09 21:36:52]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[dvonbeck, 2016-08-09 21:36:52]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[egdaniel, 2016-08-12 17:37:06]

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrDrawContext.cpp#n...
src/gpu/GrDrawContext.cpp:398:
batch.reset(GrRectRenderer::CreateAnalyticRectBatch(paint.getColor(),
viewMatrix,
Why not put the decision on which batch to draw in
GrRectBatchFactory::CreateAAFill and have that guy return the appropriate batch?
You'd need to pass the paint into him and not just the color.

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp
File src/gpu/GrRectRenderer.cpp (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp#...
src/gpu/GrRectRenderer.cpp:106: vertBuilder->codeAppendf("%s = %s;",
widthHeightVary.vsOut(), rgp.inWidthHeight()->fName);
100 chars

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp#...
src/gpu/GrRectRenderer.cpp:127: fragBuilder->codeAppendf("float insetW =
min(1.0, %s.x) - 0.5;", widthHeightVary.fsIn());
100 chars

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.h
File src/gpu/GrRectRenderer.h (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.h#ne...
src/gpu/GrRectRenderer.h:27: class GrRectRenderer {
Lets move this class into the batches subdirectory. Also since it is not the
rect renderer for all rects, lets call the class GrAnalyticRectBatch?

[dvonbeck, 2016-08-12 18:29:49]

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrDrawContext.cpp#n...
src/gpu/GrDrawContext.cpp:398:
batch.reset(GrRectRenderer::CreateAnalyticRectBatch(paint.getColor(),
viewMatrix,
On 2016/08/12 17:37:06, egdaniel wrote:
> Why not put the decision on which batch to draw in
> GrRectBatchFactory::CreateAAFill and have that guy return the appropriate
batch?
> You'd need to pass the paint into him and not just the color.

Done.

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp
File src/gpu/GrRectRenderer.cpp (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp#...
src/gpu/GrRectRenderer.cpp:106: vertBuilder->codeAppendf("%s = %s;",
widthHeightVary.vsOut(), rgp.inWidthHeight()->fName);
On 2016/08/12 17:37:06, egdaniel wrote:
> 100 chars

Done.

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.cpp#...
src/gpu/GrRectRenderer.cpp:127: fragBuilder->codeAppendf("float insetW =
min(1.0, %s.x) - 0.5;", widthHeightVary.fsIn());
On 2016/08/12 17:37:06, egdaniel wrote:
> 100 chars

Done.

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.h
File src/gpu/GrRectRenderer.h (right):

https://codereview.chromium.org/2230513004/diff/1/src/gpu/GrRectRenderer.h#ne...
src/gpu/GrRectRenderer.h:27: class GrRectRenderer {
On 2016/08/12 17:37:06, egdaniel wrote:
> Lets move this class into the batches subdirectory. Also since it is not the
> rect renderer for all rects, lets call the class GrAnalyticRectBatch?

Done.

[egdaniel, 2016-08-12 18:33:11]

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
File src/gpu/batches/GrRectBatchFactory.h (right):

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.h:17: #include "GrAnalyticRectBatch.h"
alphabetize this

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.h:42: inline GrDrawBatch*
CreateAAFill(GrPaint paint,
make this const ref for paint

[dvonbeck, 2016-08-12 18:43:10]

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
File src/gpu/batches/GrRectBatchFactory.h (right):

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.h:17: #include "GrAnalyticRectBatch.h"
On 2016/08/12 18:33:11, egdaniel wrote:
> alphabetize this

Done.

https://codereview.chromium.org/2230513004/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.h:42: inline GrDrawBatch*
CreateAAFill(GrPaint paint,
On 2016/08/12 18:33:11, egdaniel wrote:
> make this const ref for paint

Done.

[egdaniel, 2016-08-12 18:55:22]

lgtm

[dvonbeck, 2016-08-12 18:57:25]

The CQ bit was checked by dvonbeck@google.com

[commit-bot: I haz the power, 2016-08-12 18:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:50:38]

Description was changed from

==========
Re-adding analytical GeoProc for rectangles

Adapted old GeoProc because its knowledge of the geometry is helpful for
computing the distance vector:
https://skia.googlesource.com/skia/+/6006d0f8c4f19d19a12de20826f731f52ac822a7...

Added distance vector capabilities to this GeoProc.

Modified GrDrawContext to used this GeoProc when drawing anti-aliased vectors
with a shader that requires distance vectors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004
==========

to

==========
Re-adding analytical GeoProc for rectangles

Adapted old GeoProc because its knowledge of the geometry is helpful for
computing the distance vector:
https://skia.googlesource.com/skia/+/6006d0f8c4f19d19a12de20826f731f52ac822a7...

Added distance vector capabilities to this GeoProc.

Modified GrDrawContext to used this GeoProc when drawing anti-aliased vectors
with a shader that requires distance vectors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004

Committed:
https://skia.googlesource.com/skia/+/09e12a6d4a75d281c47e00a64eeba893ba096f9e
==========

[commit-bot: I haz the power, 2016-08-12 19:50:40]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/09e12a6d4a75d281c47e00a64eeba893ba096f9e