Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2818)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo
Patch Set: Rename SnippetsObserver to ContentSuggestionsSourceObserver Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
index 647487e9cb5f723e8e3dfd15884a8de9da6d18c9..8dced92e65ecb7c92f8002d90ab573e3ffcb0fb5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.ntp.snippets;
import android.support.v7.widget.RecyclerView;
import android.view.LayoutInflater;
+import android.widget.TextView;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.UiConfig;
@@ -23,6 +24,7 @@ public class SnippetHeaderViewHolder extends NewTabPageViewHolder {
private final int mMaxSnippetHeaderHeight;
private final int mMaxPeekPadding;
+ private final TextView mHeaderTextView;
private final NewTabPageRecyclerView mRecyclerView;
private SnippetHeaderListItem mHeader;
Michael van Ouwerkerk 2016/08/09 13:52:20 Let's disambiguate this one from mHeaderTextView b
Philipp Keck 2016/08/09 16:15:07 Done.
@@ -39,6 +41,7 @@ public class SnippetHeaderViewHolder extends NewTabPageViewHolder {
mMaxPeekPadding = itemView.getResources().getDimensionPixelSize(
R.dimen.snippets_padding_and_peeking_card_height);
+ mHeaderTextView = (TextView) itemView.findViewById(R.id.suggestions_section_header_text);
mRecyclerView = recyclerView;
MarginResizer.createWithViewAdapter(itemView, config);
}
@@ -78,6 +81,7 @@ public class SnippetHeaderViewHolder extends NewTabPageViewHolder {
* Update the view for the fade in/out and heading height.
*/
public void updateDisplay() {
+ mHeaderTextView.setText(mHeader.getHeaderText());
RecyclerView.LayoutParams params = (RecyclerView.LayoutParams) itemView.getLayoutParams();
int headerHeight = getHeaderHeight();

Powered by Google App Engine
This is Rietveld 408576698