chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java - Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo

Patch Set: Rename SnippetsObserver to ContentSuggestionsSourceObserver Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/ContentSuggestionsSource.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/ContentSuggestionsSource.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderListItem.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

index 300ec76619ec008b21d464dcbfb7f249512504a5..81fc55508084f713de661cbd01c9d098ff86dc3a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

@@ -68,7 +68,7 @@ public class SnippetArticleViewHolder extends CardViewHolder

private static final int ID_REMOVE = 4;

private final NewTabPageManager mNewTabPageManager;

- private final SnippetsSource mSnippetsSource;

+ private final ContentSuggestionsSource mSnippetsSource;

Michael van Ouwerkerk 2016/08/09 13:52:20 Please update the variable name accordingly.

Philipp Keck 2016/08/09 16:15:07 Done.

private final TextView mHeadlineTextView;

private final TextView mPublisherTextView;

private final TextView mArticleSnippetTextView;

@@ -90,7 +90,7 @@ public class SnippetArticleViewHolder extends CardViewHolder

* @param uiConfig The NTP UI configuration object used to adjust the article UI.

public SnippetArticleViewHolder(NewTabPageRecyclerView parent, NewTabPageManager manager,

- SnippetsSource snippetsSource, UiConfig uiConfig) {

+ ContentSuggestionsSource snippetsSource, UiConfig uiConfig) {

Michael van Ouwerkerk 2016/08/09 13:52:20 Please update the param name accordingly, here and

Philipp Keck 2016/08/09 16:15:07 Done.

super(R.layout.new_tab_page_snippets_card, parent, uiConfig);

mNewTabPageManager = manager;

@@ -254,7 +254,7 @@ public class SnippetArticleViewHolder extends CardViewHolder

} else {

mThumbnailView.setImageResource(R.drawable.ic_snippet_thumbnail_placeholder);

mImageCallback = new FetchImageCallback(this, mArticle);

- mSnippetsSource.fetchSnippetImage(mArticle, mImageCallback);

+ mSnippetsSource.fetchSuggestionImage(mArticle, mImageCallback);

}

// Set the favicon of the publisher.