chrome/android/java/res/layout/new_tab_page_snippets_header.xml - Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_header.xml

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo

Patch Set: Rename SnippetsObserver to ContentSuggestionsSourceObserver Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page_snippets_header.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_header.xml b/chrome/android/java/res/layout/new_tab_page_snippets_header.xml

index f13a91d90ecce789b0e0726f7608551b27a9d076..82be3943619f6e13b76c6da0f7981301ffb2abdc 100644

--- a/chrome/android/java/res/layout/new_tab_page_snippets_header.xml

+++ b/chrome/android/java/res/layout/new_tab_page_snippets_header.xml

@@ -5,10 +5,9 @@

<TextView

xmlns:android="http://schemas.android.com/apk/res/android"

- android:id="@+id/snippets_list_header"

+ android:id="@+id/suggestions_section_header_text"

Michael van Ouwerkerk 2016/08/09 13:52:20 nit: omit the _text suffix, it seems redundant

Philipp Keck 2016/08/09 16:15:06 Done.

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:text="@string/snippets_header"

android:textColor="@color/snippets_list_header_text_color"

android:textSize="12sp"

android:paddingStart="@dimen/snippets_padding_and_peeking_card_height"