chrome/android/java/res/layout/new_tab_page_snippets_header.xml - Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_header.xml

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo

Patch Set: Rename SnippetsObserver to ContentSuggestionsSourceObserver Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <TextView	6 <TextView

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 android:id="@+id/snippets_list_header"	8 android:id="@+id/suggestions_section_header_text"
	Michael van Ouwerkerk 2016/08/09 13:52:20 nit: omit the _text suffix, it seems redundant nit: omit the _text suffix, it seems redundant Philipp Keck 2016/08/09 16:15:06 Done. Show quoted text On 2016/08/09 13:52:20, Michael van Ouwerkerk wrote: > nit: omit the _text suffix, it seems redundant Done.
9 android:layout_width="match_parent"	9 android:layout_width="match_parent"

10 android:layout_height="wrap_content"	10 android:layout_height="wrap_content"

11 android:text="@string/snippets_header"

12 android:textColor="@color/snippets_list_header_text_color"	11 android:textColor="@color/snippets_list_header_text_color"

13 android:textSize="12sp"	12 android:textSize="12sp"

14 android:paddingStart="@dimen/snippets_padding_and_peeking_card_height"	13 android:paddingStart="@dimen/snippets_padding_and_peeking_card_height"

15 android:paddingTop="10dp"	14 android:paddingTop="10dp"

16 android:gravity="start\|center_vertical" />	15 android:gravity="start\|center_vertical" />

OLD	NEW