Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing test name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.cc
diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc
index ed8c1cca6ff6adb5be2608c9154c65fce5de3752..09f0e4b020bf7ba7398cbd727b405a0015ade221 100644
--- a/ui/touch_selection/touch_selection_controller.cc
+++ b/ui/touch_selection/touch_selection_controller.cc
@@ -46,8 +46,7 @@ TouchSelectionController::Config::Config()
: max_tap_duration(base::TimeDelta::FromMilliseconds(300)),
tap_slop(8),
enable_adaptive_handle_orientation(false),
- enable_longpress_drag_selection(false),
- show_on_tap_for_empty_editable(false) {}
+ enable_longpress_drag_selection(false) {}
TouchSelectionController::Config::~Config() {
}
@@ -223,7 +222,7 @@ bool TouchSelectionController::WillHandleTapEvent(const gfx::PointF& location,
activate_selection_automatically_ = false;
}
ShowInsertionHandleAutomatically();
- if (selection_empty_ && !config_.show_on_tap_for_empty_editable)
+ if (selection_empty_)
DeactivateInsertion();
ForceNextUpdateIfInactive();
return false;
@@ -497,7 +496,7 @@ void TouchSelectionController::OnInsertionChanged() {
if ((response_pending_input_event_ == TAP ||
response_pending_input_event_ == REPEATED_TAP) &&
- selection_empty_ && !config_.show_on_tap_for_empty_editable) {
+ selection_empty_) {
HideAndDisallowShowingAutomatically();
return;
}
« no previous file with comments | « ui/touch_selection/touch_selection_controller.h ('k') | ui/touch_selection/touch_selection_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698