Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(553)

Issue 2230193002: remoting: Use stl utilities from the base namespace (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
Lambros
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remoting: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/bd9c35c6829bc74effde22eb8c5c0fe920ca30b4 Cr-Commit-Position: refs/heads/master@{#411604}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -32 lines) Patch
M remoting/base/buffered_socket_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/jni/jni_display_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/codec/audio_decoder_opus.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/codec/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_verbatim.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/linux/audio_pipe_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_reader.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/security_key/security_key_message_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/security_key/security_key_message_reader_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_message_writer_impl_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/touch_injector_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years ago (2016-08-10 14:25:35 UTC) #7
Lambros
lgtm
4 years ago (2016-08-10 16:35:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230193002/20001
4 years ago (2016-08-12 12:04:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-08-12 12:08:13 UTC) #17
commit-bot: I haz the power
4 years ago (2016-08-12 12:10:56 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd9c35c6829bc74effde22eb8c5c0fe920ca30b4
Cr-Commit-Position: refs/heads/master@{#411604}

Powered by Google App Engine
This is Rietveld 408576698