remoting/host/native_messaging/native_messaging_writer_unittest.cc - Issue 2230193002: remoting: Use stl utilities from the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/native_messaging/native_messaging_writer_unittest.cc

Issue 2230193002: remoting: Use stl utilities from the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/native_messaging/native_messaging_reader.cc ('k') | remoting/host/security_key/security_key_message_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/native_messaging/native_messaging_writer_unittest.cc

diff --git a/remoting/host/native_messaging/native_messaging_writer_unittest.cc b/remoting/host/native_messaging/native_messaging_writer_unittest.cc

index 37963c06734b88e86d3a30080932f2df09364d47..b2f7ccfe59c2ed0eba20951d197bc90dd768e01f 100644

--- a/remoting/host/native_messaging/native_messaging_writer_unittest.cc

+++ b/remoting/host/native_messaging/native_messaging_writer_unittest.cc

@@ -48,7 +48,7 @@ TEST_F(NativeMessagingWriterTest, GoodMessage) {

int read = read_file_.ReadAtCurrentPos(reinterpret_cast<char*>(&length), 4);

EXPECT_EQ(4, read);

std::string content(length, '\0');

- read = read_file_.ReadAtCurrentPos(string_as_array(&content), length);

+ read = read_file_.ReadAtCurrentPos(base::string_as_array(&content), length);

EXPECT_EQ(static_cast<int>(length), read);

// |content| should now contain serialized |message|.

@@ -80,7 +80,7 @@ TEST_F(NativeMessagingWriterTest, SecondMessage) {

read = read_file_.ReadAtCurrentPos(reinterpret_cast<char*>(&length), 4);

EXPECT_EQ(4, read) << "i = " << i;

content.resize(length);

- read = read_file_.ReadAtCurrentPos(string_as_array(&content), length);

+ read = read_file_.ReadAtCurrentPos(base::string_as_array(&content), length);

EXPECT_EQ(static_cast<int>(length), read) << "i = " << i;

}