Issue 223016: Fix a bug where if a PAC script ended with a comment and no newline, it would...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223016: Fix a bug where if a PAC script ended with a comment and no newline, it would... (Closed)

Created:
11 years, 3 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review), tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bug where if a PAC script ended with a comment and no newline, it would fail to parse. The library is now compiled and executed in a separate pass, rather than trying to append the source segments. BUG=http://crbug.com/22864 TEST=ProxyResolverV8Test.TrailingComment Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27035

Patch Set 1 #

Patch Set 2 : update a comment #

Total comments: 2

Patch Set 3 : remove unused TryCatch #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -16 lines)			Patch
A	net/data/proxy_resolver_v8_unittest/ends_with_comment.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/proxy/proxy_resolver_v8.cc	View	1 2	3 chunks	+36 lines, -16 lines	0 comments	Download
M	net/proxy/proxy_resolver_v8_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM! I'm glad you tracked this down. http://codereview.chromium.org/223016/diff/5/6 File net/proxy/proxy_resolver_v8.cc (left): http://codereview.chromium.org/223016/diff/5/6#oldcode133 Line 133: v8::TryCatch ...

11 years, 3 months ago (2009-09-24 00:05:37 UTC) #2

eroman

11 years, 3 months ago (2009-09-24 00:10:07 UTC) #3

Thanks for the speedy review!

http://codereview.chromium.org/223016/diff/5/6
File net/proxy/proxy_resolver_v8.cc (left):

http://codereview.chromium.org/223016/diff/5/6#oldcode133
Line 133: v8::TryCatch try_catch;
On 2009/09/24 00:05:37, wtc wrote:
> We can delete try_catch, right?

Done.

Expand Messages | Collapse Messages