Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: net/data/proxy_resolver_v8_unittest/ends_with_comment.js

Issue 223016: Fix a bug where if a PAC script ended with a comment and no newline, it would... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: remove unused TryCatch Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/data/proxy_resolver_v8_unittest/ends_with_comment.js
===================================================================
--- net/data/proxy_resolver_v8_unittest/ends_with_comment.js (revision 0)
+++ net/data/proxy_resolver_v8_unittest/ends_with_comment.js (revision 0)
@@ -0,0 +1,8 @@
+function FindProxyForURL(url, host) {
+ return "PROXY success:80";
+}
+
+// We end the script with a comment (and no trailing newline).
+// This used to cause problems, because internally ProxyResolverV8
+// would append some functions to the script; the first line of
+// those extra functions was being considered part of the comment.
Property changes on: net/data/proxy_resolver_v8_unittest/ends_with_comment.js
___________________________________________________________________
Name: svn:eol-style
+ LF
« no previous file with comments | « no previous file | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698