Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2230153004: Fix a failing IME test caused by ImeThread (Closed)

Created:
4 years, 4 months ago by Changwan Ryu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, yabinh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a failing IME test caused by ImeThread This ensures that we run all the InputConnection APIs on IME thread when applicable. BUG=636370 Committed: https://crrev.com/537f003e8a0ec6664d12db9852585a8749bedfa7 Cr-Commit-Position: refs/heads/master@{#411150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java View 2 chunks +6 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Changwan Ryu
Alex, could you take a look? (and please CQ if looks good... thanks!)
4 years, 4 months ago (2016-08-10 16:26:04 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 4 months ago (2016-08-10 21:23:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230153004/1
4 years, 4 months ago (2016-08-10 21:24:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 21:34:32 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:36:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/537f003e8a0ec6664d12db9852585a8749bedfa7
Cr-Commit-Position: refs/heads/master@{#411150}

Powered by Google App Engine
This is Rietveld 408576698