Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2319)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java

Issue 2230153004: Fix a failing IME test caused by ImeThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
index 159d73a5fdef25a55ad93ad11acaf92954c58ae8..f6352c10effe6c822a9253446838ee4afa585e7e 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
@@ -16,6 +16,8 @@ import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
+import java.util.concurrent.Callable;
+
/**
* Integration tests for text input for Android L (or above) features.
*/
@@ -60,12 +62,13 @@ public class ImeLollipopTest extends ImeTest {
waitForUpdateCursorAnchorInfoComposingText("abcd");
}
- private void requestCursorUpdates(final int cursorUpdateMode) {
+ private void requestCursorUpdates(final int cursorUpdateMode) throws Exception {
final InputConnection connection = mConnection;
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ runBlockingOnImeThread(new Callable<Void>() {
@Override
- public void run() {
+ public Void call() {
connection.requestCursorUpdates(cursorUpdateMode);
+ return null;
}
});
}
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698