Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: appengine/findit/handlers/test/build_failure_test.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/test/build_failure_test.py
diff --git a/appengine/findit/handlers/test/build_failure_test.py b/appengine/findit/handlers/test/build_failure_test.py
index e6936903ff1f8d41e453c4f696a12ed294695db0..9a016f4afc9db342022fb2667d8c44f4907e24a5 100644
--- a/appengine/findit/handlers/test/build_failure_test.py
+++ b/appengine/findit/handlers/test/build_failure_test.py
@@ -13,6 +13,7 @@ import webtest
from handlers import build_failure
from handlers import handlers_util
from handlers import result_status
+from model.base_build_model import BaseBuildModel
from model.wf_analysis import WfAnalysis
from model.wf_try_job import WfTryJob
from model import analysis_status
@@ -122,7 +123,8 @@ class BuildFailureTest(wf_testcase.WaterfallTestCase):
self.taskqueue_stub.FlushQueue(queue['name'])
def MockedGetAllTryJobResults(master_name, builder_name, build_number, _):
- build_key = '%s/%s/%d' % (master_name, builder_name, build_number)
+ build_key = BaseBuildModel.CreateBuildId(
stgao 2016/09/28 00:13:27 There is another new code for this in build_util.p
chanli 2016/09/30 20:41:01 I thought I deleted that part of code... Done
+ master_name, builder_name, build_number)
return SAMPLE_TRY_JOB_INFO.get(build_key, None)
self.mock(handlers_util, 'GetAllTryJobResults', MockedGetAllTryJobResults)

Powered by Google App Engine
This is Rietveld 408576698