[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/handlers/test/build_failure_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 
 from google.appengine.ext import testbed
 
 import webapp2
 import webtest
 
 from handlers import build_failure
 from handlers import handlers_util
 from handlers import result_status
+from model.base_build_model import BaseBuildModel
 from model.wf_analysis import WfAnalysis
 from model.wf_try_job import WfTryJob
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 from waterfall.test import wf_testcase
 
 # Root directory appengine/findit.
 ROOT_DIR = os.path.join(os.path.dirname(__file__),
                         os.path.pardir, os.path.pardir)
@@ skipping 89 matching lines @@
   def setUp(self):
     super(BuildFailureTest, self).setUp()
 
     # Setup clean task queues.
     self.testbed.init_taskqueue_stub(root_path=ROOT_DIR)
     self.taskqueue_stub = self.testbed.get_stub(testbed.TASKQUEUE_SERVICE_NAME)
     for queue in self.taskqueue_stub.GetQueues():
       self.taskqueue_stub.FlushQueue(queue['name'])
 
     def MockedGetAllTryJobResults(master_name, builder_name, build_number, _):
-      build_key = '%s/%s/%d' % (master_name, builder_name, build_number)
+      build_key = BaseBuildModel.CreateBuildId(

[stgao, 2016/09/28 00:13:27]

There is another new code for this in build_util.py
Why do we have the duplicate?

[chanli, 2016/09/30 20:41:01]

I thought I deleted that part of code... Done

+          master_name, builder_name, build_number)
       return SAMPLE_TRY_JOB_INFO.get(build_key, None)
     self.mock(handlers_util, 'GetAllTryJobResults', MockedGetAllTryJobResults)
 
   def testGetTriageHistoryWhenUserIsNotAdmin(self):
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.status = analysis_status.COMPLETED
     analysis.triage_history = [
         {
             'triage_timestamp': 1438380761,
             'user_name': 'test',
@@ skipping 626 matching lines @@
         },
         'failed': False,
     }
 
     build_url = buildbot.CreateBuildUrl('m', 'b', 123)
     response = self.test_app.get('/build-failure',
                                  params={'url': build_url, 'format': 'json'})
 
     self.assertEquals(200, response.status_int)
     self.assertEqual(expected_try_job_result, response.json_body['try_job'])