Retain fewer names for reflection.

Retain fewer names for reflection.

R=johnniwinther@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25878

[Johnni Winther, 2013-08-07 10:47:34]

lgtm

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
(right):

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1405:
bool retainGetter(Element element) => isNeededForReflection(element);
Rename these three to shouldRetainX, isXRetained or similar to indicate that
they are lookups and not registrations. And add documentation (if not already
present in Backend).

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1482:
bool rememberNameOf(Element element) {
Ditto.

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1291:
String getReflectionName(elementOrSelector, String mangledName) {
Add documentation to this method.

[ahe, 2013-08-07 14:03:17]

Thank you, Johnni!

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
(right):

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1405:
bool retainGetter(Element element) => isNeededForReflection(element);
On 2013/08/07 10:47:34, Johnni Winther wrote:
> Rename these three to shouldRetainX, isXRetained or similar to indicate that
> they are lookups and not registrations. And add documentation (if not already
> present in Backend).

Done.

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1482:
bool rememberNameOf(Element element) {
On 2013/08/07 10:47:34, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/22301009/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1291:
String getReflectionName(elementOrSelector, String mangledName) {
On 2013/08/07 10:47:34, Johnni Winther wrote:
> Add documentation to this method.

Done.

[karlklose, 2013-08-07 15:31:20]

Delta to patchset 3 LGTM.

https://codereview.chromium.org/22301009/diff/11004/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart (right):

https://codereview.chromium.org/22301009/diff/11004/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart:189: if
(librariesWithoutUsage.isEmpty) {
Could we warn if there is an import with and one without a MirrorsUsed
annotation?

[ahe, 2013-08-07 15:44:17]

Thank you, Karl!

https://codereview.chromium.org/22301009/diff/11004/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart (right):

https://codereview.chromium.org/22301009/diff/11004/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart:189: if
(librariesWithoutUsage.isEmpty) {
On 2013/08/07 15:31:20, karlklose wrote:
> Could we warn if there is an import with and one without a MirrorsUsed
> annotation?

Yes. Filed http://dartbug.com/12297.

[ahe, 2013-08-07 15:44:44]

Committed patchset #4 manually as r25878 (presubmit successful).